fix(growth): replace BASH_SOURCE with git rev-parse (closes #3303) - #3317
Closed
AhmedTMM wants to merge 1 commit into
Closed
fix(growth): replace BASH_SOURCE with git rev-parse (closes #3303)#3317AhmedTMM wants to merge 1 commit into
AhmedTMM wants to merge 1 commit into
Conversation
Closes OpenRouterLabs#3303. BASH_SOURCE resolves to /dev/fd/XX under bash <(curl ...) which violates .claude/rules/shell-scripts.md. Switched to git rev-parse --show-toplevel which always works regardless of invocation method. Applied only to growth.sh per the issue scope. The same pattern exists in refactor.sh, security.sh, and discovery.sh but those are separate issues and those scripts are also never curl-piped.
Collaborator
Author
|
Closing — the underlying issue #3303 is a false positive (internal script, never curl-piped). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3303. Replaces
BASH_SOURCE[0]-based path resolution ingrowth.shwithgit rev-parse --show-toplevel, which works regardless of invocation method.Change
Note
The same
BASH_SOURCEpattern exists inrefactor.sh,security.sh, anddiscovery.sh. Those are not touched here per the issue scope — they're also never curl-piped (always executed directly on the VM bytrigger-server.ts), so the practical risk is zero, but the rule violation is technically real.Test plan
bash -n growth.sh— syntax clean